Skip to content

Conversation

@MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 14, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

just curious to see what fails, and I'm questioning whether it's worth adding complexity to support this

Is anyone particularly attached to this? If not, I'd suggest deprecating, because:

  • the workaround on the users' side is very simple
  • __setitem__ is already incredibly complex and spaghettified
  • there's only 3 tests which use this pattern
  • there's little time left until 3.0, and I don't have time to work on this further before 2.2

NOTE: I'm not actually sure that disallowing this is even the way to go, will sleep on it

@MarcoGorelli MarcoGorelli force-pushed the multicolumnwise-rowwise branch from 6a05642 to a079db6 Compare January 14, 2024 11:01
@simonjayhawkins simonjayhawkins added Indexing Related to indexing on series/frames, not to indexes themselves Deprecate Functionality to remove in pandas labels Feb 7, 2024
@MarcoGorelli
Copy link
Member Author

actually addressed this in the end, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecate Functionality to remove in pandas Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants